Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor removeEditorsNSData #1557

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Refactor removeEditorsNSData #1557

merged 1 commit into from
Sep 10, 2021

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Sep 4, 2021

  • covered with types
  • migrated to visitor plugin api
  • got rid from parseName utility in favour of simple string operations

@TrySound
Refactor removeEditorsNSData
c599104 
- covered with types
- migrated to visitor plugin api
- got rid from parseName utility in favour of simple string operations
omgovich
omgovich approved these changes Sep 10, 2021
View reviewed changes
Copy link
Collaborator

@omgovich omgovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@TrySound TrySound merged commit f587aae into master Sep 10, 2021
@TrySound TrySound deleted the refactor-remove-editors-ns-data branch September 10, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omgovich omgovich omgovich approved these changes

@matheus1lva matheus1lva matheus1lva approved these changes

@renatorib renatorib Awaiting requested review from renatorib

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrySound @omgovich @matheus1lva